Skip to content

Adding metric evaluator to Trainer - #8

Merged
muhrin merged 1 commit into
camml-lab:developfrom
giotre:develop
Jun 16, 2026
Merged

Adding metric evaluator to Trainer#8
muhrin merged 1 commit into
camml-lab:developfrom
giotre:develop

Conversation

@giotre

@giotre giotre commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Modified files:

  • src/reax/training/trainer.py
    • Add optional metric_evaluator argument to Trainer.
    • Expose it through a read-only metric_evaluator property.

Comment thread src/reax/training/trainer.py Outdated
self._automatic_optimization = True
self._optimizers = []
self._stage: stages.Stage | None = None
self._metric_evaluator = metric_evaluator

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be the DefaultEvaluator if None?

@giotre
giotre force-pushed the develop branch 4 times, most recently from d64c00e to 14f94a6 Compare June 16, 2026 16:46
@muhrin
muhrin merged commit 2299b75 into camml-lab:develop Jun 16, 2026
7 checks passed
@codecov-commenter

codecov-commenter commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/reax/training/trainer.py 80.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Files with missing lines Coverage Δ
src/reax/training/trainer.py 89.75% <80.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants