Conversation
7 tasks
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 Improvements
|
💡 개선 사항
|
💡 개선 사항
|
philbae0
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PENDING(받았지만 연결 전)을 추가하고, 소켓 없이 방치되는 통화를 걷는 스위퍼를 붙였다.Related Issue
Describe your code
AI 발신 흐름
CallReservation엔티티 + 상태(SCHEDULED/FIRED/CANCELED)CallReservationWorker/CallReservationService.fireGET /calls/incoming(RINGING 최신 1건)PATCH /calls/{callId}/accept(wsTicket 발급, dial과 대칭) / 거절PATCH /calls/{callId}/reject상태 머신
PENDING신설:RINGING(안 받음) →PENDING(받았지만 WS 연결 전) →IN_PROGRESSCallTimeoutWorker:RINGING→MISSED(60초) /PENDING→CANCELED(60초)PATCH /calls/{callId}/end(사용자가 통화 중 끊는 경로, 상태 마감 + 소켓 정리)예약 조회/수정
GET /call-reservations(오늘 하루 대기 중 예약, 가까운 시각순)PATCH /call-reservations/{reservationId}(예약 시각 변경)예약 생성
CallReservationService.reserve(relationshipId, scheduledAt)— API 없이 서비스 메서드만Call↔CallReservation연결 (어느 예약이 울린 통화인지 추적)스크린샷/결과 (Optional)
논의사항/질문 (To Reviewers)
reserve()는 아직 호출부가 없습니다. 예약을 만드는 코드가 아예 없어서 SQL로 넣어 테스트하던 상태라, 생성 로직만 미리 만들어 뒀습니다. 예약 생성 흐름(대화 중 약속 / AI 서버 판단 등)이 정해지면 그쪽에서 이 메서드를 호출해 주세요.reserve(relationshipId, scheduledAt)→reservationId반환.범위 밖
RINGING통화만 생성됩니다. 수락/거절은 accept·reject API로 테스트했습니다.callTicketBalance) 차감,aiSummary·audioUrl생성Checklist