docs: auto-update for PR #2968 — test(wasm-abi): restore ignored normalize_type tests#2988
Closed
meroreviewer[bot] wants to merge 2 commits into
Closed
docs: auto-update for PR #2968 — test(wasm-abi): restore ignored normalize_type tests#2988meroreviewer[bot] wants to merge 2 commits into
meroreviewer[bot] wants to merge 2 commits into
Conversation
Contributor
Author
There was a problem hiding this comment.
🤖 AI Code Reviewer
Reviewed by 1 agents | Quality score: 85% | Review time: 201.1s
✅ No Issues Found
All agents reviewed the code and found no issues. LGTM! 🎉
🤖 Generated by AI Code Reviewer | Review ID: review-9c8dfd6a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Documentation Update
Opened automatically after PR #2968 merged.
Each block shows the documentation change as a diff (added lines in green, removed in red); expand "Why this changed" for the source rationale.
Documentation changes
architecture/abi-conformance.html— Reject non-u8 fixed-array element types with UnsupportedArrayElement; Skip String-key validation for CRDT map types to avoid regression; Re-enable 11 previously-ignored normalize_type testsWhy this changed (source: PR #2968)
Previously,
[T; N]arrays whose element type was notu8silently fell through to list normalization, producing an incorrect ABI representation. Now, any fixed-size array with a non-u8 element type immediately returnsNormalizeError::UnsupportedArrayElementinstead.The key-validation logic introduced for standard maps is guarded by an
is_crdt_mapcheck that skips validation forUnorderedMap,SortedMap, andAuthoredMap. Without this guard, existing app code usingUnorderedMap<Slug, V>would fail ABI emission after the stricter validation was applied universally.Eleven tests in
crates/wasm-abi/tests/normalize.rsthat were marked#[ignore]are now active. They cover BTreeMap key validation, invalid map keys,[u8; N]array acceptance, non-u8 array rejection,Vec<u8>bytes, newtype bytes, record/variant types, unknown external types, unit type, nested generics, and complex nested scenarios. All 21 normalize tests now pass.architecture/error-flows.html— Collect normalize_type errors in AbiEmitter instead of panickingWhy this changed (source: PR #2968)
Added a
normalize_errors: Vec<String>field toAbiEmitterand anormalize_or_recordhelper method. All call sites that previously callednormalize_type(...).unwrap()or.unwrap_or_else(|e| panic!(...))now callnormalize_or_record, which records the error with a descriptive context string and returns a placeholderstringtype so visitation can continue. After all AST passes,emit_manifest_from_cratechecks the collected errors and returns them as a combined diagnostic error instead of allowing a panic to propagate.Generated by
ai-reviewer update-docs. Nothing was auto-merged.