Skip to content

Add StructArmed to QA #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samsonasik wants to merge 7 commits into
base: 5.x
Choose a base branch
from
Open

Add StructArmed to QA #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3a9f9a7
Add StructArmed to QA
samsonasik May 24, 2026
126e844
final touch: fix reference
samsonasik May 24, 2026
8d0220b
final touch: fix reference
samsonasik May 24, 2026
52834b8
move no namespace on purpose to stubs with classmap
samsonasik May 24, 2026
3426c18
move source different namespace to stubs
samsonasik May 24, 2026
8ca223f
move source different namespace to stubs
samsonasik May 24, 2026
4b86db4
really final touch: move require-dev to Makefile
samsonasik May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,6 @@ jobs:

- name: Run PHP CodeSniffer
run: vendor/bin/phpcs --report=checkstyle | cs2pr

- name: Run StructArmed
run: vendor/bin/structarmed analyze
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ DEV_DEPENDENCIES = cakephp/cakephp:5.x-dev \
cakephp/cakephp-codesniffer:^5.0 \
mikey179/vfsstream:^1.6.8 \
phpunit/phpunit:^10.5.38 \
cakephp/migrations:^4.5.0
cakephp/migrations:^4.5.0 \
boundwize/structarmed:^0.7.7

install-dev:
composer require --dev $(DEV_DEPENDENCIES)
Expand Down
5 changes: 4 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@
"autoload-dev": {
"psr-4": {
"Cake\\Upgrade\\Test\\TestCase\\": "tests/TestCase/"
}
},
"classmap": [
"stubs"
]
},
"prefer-stable": true,
"minimum-stability": "dev",
Expand Down
9 changes: 9 additions & 0 deletions structarmed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

declare(strict_types=1);

use Boundwize\StructArmed\Architecture;
use Boundwize\StructArmed\Preset\Preset;

return Architecture::define()
->withPreset(Preset::PSR4());
0 ...icCallToUseStatementRector/Source/App.php → stubs/App.php
View file
Open in desktop
File renamed without changes.
0 ...icCallToUseStatementRector/Source/Xml.php → stubs/Cake/Utility/Xml.php
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions tests/TestCase/Rector/MethodCall/RemoveMethodCallArgsRector/Fixture/fixture.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?php

namespace Cake\Upgrade\Test\TestCase\Rector\MethodCall\AddMethodCallArgsRectorTest\Fixture;
namespace Cake\Upgrade\Test\TestCase\Rector\MethodCall\RemoveMethodCallArgsRector\Fixture;

use Cake\Upgrade\Test\TestCase\Rector\MethodCall\AddMethodCallArgsRector\Source\SomeModelType;
use Cake\Upgrade\Test\TestCase\Rector\MethodCall\RemoveMethodCallArgsRector\Source\SomeModelType;

function addMethodCallArgs()
{
Expand All @@ -15,9 +15,9 @@ function addMethodCallArgs()
-----
<?php

namespace Cake\Upgrade\Test\TestCase\Rector\MethodCall\AddMethodCallArgsRectorTest\Fixture;
namespace Cake\Upgrade\Test\TestCase\Rector\MethodCall\RemoveMethodCallArgsRector\Fixture;

use Cake\Upgrade\Test\TestCase\Rector\MethodCall\AddMethodCallArgsRector\Source\SomeModelType;
use Cake\Upgrade\Test\TestCase\Rector\MethodCall\RemoveMethodCallArgsRector\Source\SomeModelType;

function addMethodCallArgs()
{
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCase/Rector/MethodCall/RemoveMethodCallArgsRector/Source/SomeModelType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace Cake\Upgrade\Test\TestCase\Rector\MethodCall\AddMethodCallArgsRector\Source;
namespace Cake\Upgrade\Test\TestCase\Rector\MethodCall\RemoveMethodCallArgsRector\Source;

final class SomeModelType
{
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCase/Rector/MethodCall/RemoveMethodCallArgsRector/config/configured_rule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

use Cake\Upgrade\Rector\Rector\MethodCall\RemoveMethodCallRector;
use Cake\Upgrade\Rector\ValueObject\RemoveMethodCall;
use Cake\Upgrade\Test\TestCase\Rector\MethodCall\AddMethodCallArgsRector\Source\SomeModelType;
use Cake\Upgrade\Test\TestCase\Rector\MethodCall\RemoveMethodCallArgsRector\Source\SomeModelType;
use Rector\Config\RectorConfig;

return static function (RectorConfig $rectorConfig): void {
Expand Down