add-exchange-rate#3397
Open
konstantinullrich wants to merge 3 commits into
Open
Conversation
malik1004x
approved these changes
Jul 13, 2026
OmarHatem28
reviewed
Jul 14, 2026
OmarHatem28
left a comment
OmarHatem28
left a comment
Contributor
There was a problem hiding this comment.
@konstantinullrich fix the tests parameter name and add tests for USDTerc20 from CryptoCurrency class and from ERC20 token. probably it will fail.
so either need to modify the condition and make it explicit or make sure that this is only used in swaps, where we only get the currencies from CryptoCurrency.all
I would prefer the first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an exchange rate class for future use in Swap flow and the fiat api
Pull Request - Checklist