Skip to content
This repository was archived by the owner on Nov 22, 2021. It is now read-only.

Update template with extra task#1

Open
agc93 wants to merge 1 commit into
masterfrom
feature/update-template
Open

Update template with extra task#1
agc93 wants to merge 1 commit into
masterfrom
feature/update-template

Conversation

@agc93

@agc93 agc93 commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

@gep13 This line up with what you were talking about with an extra task to show dependencies?

@agc93 agc93 requested a review from gep13 January 12, 2018 13:28
@gep13

gep13 commented Jan 12, 2018

Copy link
Copy Markdown

Yip, that covers that part. I think it would be good to have a TaskSetup and a TaskTeardown method as well.

@gep13

gep13 commented Jan 12, 2018

Copy link
Copy Markdown

That way, all the entry points would be covered.

@gep13 gep13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get a TaskSetup and a TaskTeardown method?

@agc93

agc93 commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

Personally, like I said in chat, I don't think a TaskSetup/TaskTeardown is a good fit for a "minimum-viable" type script?

Almost no-one is using them currently, the use cases at the moment are pretty rare, and I think it adds unneeded complexity for first-time/new users.

Would that be a better fit for cake-build/example?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants