Fix/libdnsv1#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Loopia provider implementation to include an optional logging flag and upgrades module dependencies while adding additional quality checks and build targets.
- Added a Logging field to the Provider struct with corresponding configuration parsing in the Caddyfile directive.
- Upgraded go version and several dependencies in go.mod.
- Enhanced the Makefile with new targets for tidy, audit, and a modified xcaddy run command.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| loopia.go | Added Logging flag to Provider; updated constructor and directive parsing. |
| go.mod | Updated go version and dependency versions. |
| Makefile | Added new build targets and updated the run command. |
| .github/workflows/basic-checks.yml | Introduced a new workflow for basic checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.