Glossary is a WIP. Added 18F glossary to OD. Basic styling accomplished.#289
Open
jessecodescode wants to merge 4 commits into
Open
Glossary is a WIP. Added 18F glossary to OD. Basic styling accomplished.#289jessecodescode wants to merge 4 commits into
jessecodescode wants to merge 4 commits into
Conversation
ghost
assigned
Member
|
@jbotwins this looks great! We don't want to merge it until we get some more glossary terms in and the styling. We can either put some kind of a feature flag on this or comment out the initialization and hide the glossary button so it doesn't appear for users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work resolves #213 but is still a work in progress. Two issues (at least) will be created based on this one.
Description of work:
Added 18F glossary with basic styling. I made a layout change in the footer so that the Glossary button does not cover the Voters Edge content.
Previews
Large screens
Small screens