Close fiber_channel on Server#shutdown to avoid fiber leak. Fixes #110

spec/cable/server_spec.cr

@@ -18,6 +18,25 @@ describe Cable::Server do
     end
   end
 
+  describe "#shutdown" do
+    it "closes the fiber_channel so the subscribed messages fiber doesn't leak" do
+      Cable.reset_server
+      Cable.temp_config(backend_class: Cable::DevBackend) do
+        server = Cable.server
+        server.fiber_channel.closed?.should be_false
+
+        server.shutdown
+
+        server.fiber_channel.closed?.should be_true
+        # Sending to the closed channel must raise rather than silently leak.
+        expect_raises(::Channel::ClosedError) do
+          server.fiber_channel.send({"foo", "bar"})
+        end
+      end
+      Cable.reset_server
+    end
+  end
+
   describe "#active_connections_for" do
     it "accurately returns active connections for a specificic token" do
       Cable.reset_server

src/cable/server.cr

@@ -195,6 +195,9 @@ module Cable
       connections_to_close.each do |connection|
         connection.close
       end
+      # Close the channel so the `process_subscribed_messages` fiber stops
+      # blocking on `receive` and exits cleanly instead of leaking across restarts.
+      fiber_channel.close
     end
 
     def restart?
@@ -210,7 +213,7 @@ module Cable
     private def process_subscribed_messages
       server = self
       spawn(name: "Cable::Server - process_subscribed_messages") do
-        while received = fiber_channel.receive
+        while received = fiber_channel.receive?
           channel, message = received
           if channel.starts_with?("cable_internal")
             identifier = channel.split('/').last