Skip to content

Adds minimal support for J2606 2.0#146

Open
c4deszes wants to merge 1 commit into
masterfrom
feature/j2602_support
Open

Adds minimal support for J2606 2.0#146
c4deszes wants to merge 1 commit into
masterfrom
feature/j2602_support

Conversation

@c4deszes
Copy link
Copy Markdown
Owner

@c4deszes c4deszes commented Dec 9, 2025

Brief

Checklist

  • Add relevant labels to the Pull Request
  • Review test results and code coverage
    • Review snapshot test results for deviations
  • Review code changes
    • Create relevant test scenarios
    • Update examples
    • Update JSON schema
  • Update documentation
    • Update examples in README
  • Update changelog
  • Update version number

Resolves

  • Describe the bug or feature and link to relevant issues

Evidence

  • Analyze how the change might impact existing code

  • Provide evidence that the feature is tested and covered properly

Support for phrases "Commander" and "Responder" in the node summary
Reset indication is added to the grammar but it's not parsed
@c4deszes c4deszes added ldf/nodes Related to LIN nodes parser Related to the LDF parsing j2602 SAE LIN standard labels Dec 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.06%. Comparing base (2de76f5) to head (894239d).

Files with missing lines Patch % Lines
ldfparser/grammar.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   96.19%   96.06%   -0.14%     
==========================================
  Files          13       13              
  Lines        1472     1474       +2     
==========================================
  Hits         1416     1416              
- Misses         56       58       +2     
Flag Coverage Δ
3.10 96.84% <80.00%> (?)
3.11 96.84% <80.00%> (+0.64%) ⬆️
3.12 96.84% <80.00%> (+0.64%) ⬆️
3.6 96.06% <80.00%> (-0.14%) ⬇️
3.7 96.06% <80.00%> (-0.14%) ⬇️
3.8 96.06% <80.00%> (-0.14%) ⬇️
3.9 96.84% <80.00%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

j2602 SAE LIN standard ldf/nodes Related to LIN nodes parser Related to the LDF parsing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant