sim: Swap keyboard-db48x-{42like,old}.png so filenames match content#1698
Open
prismv wants to merge 1 commit into
Open
sim: Swap keyboard-db48x-{42like,old}.png so filenames match content#1698prismv wants to merge 1 commit into
prismv wants to merge 1 commit into
Conversation
The visual contents of these two keyboard images were swapped relative to their filenames: `keyboard-db48x-42like.png` contained the older db48x layout, and `keyboard-db48x-old.png` contained the 42-style layout. sim.qrc resolves the runtime image via aliases derived from the keymap file's basename (`42style.png`, `legacy.png`, ...), so the wrong image was loaded for both maps — selecting `config/42style.48k` rendered the legacy face, and selecting `config/legacy.48k` rendered the 42-style face. Swap the file contents in place so the qrc aliases (unchanged) now resolve correctly: `42style.png` -> 42-style face, `legacy.png` -> older db48x face. Forum report: https://www.hpmuseum.org/forum/thread-20157-post-217541.html#pid217541
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The visual contents of these two keyboard images were swapped relative to their filenames:
keyboard-db48x-42like.pngcontained the older db48x layout, andkeyboard-db48x-old.pngcontained the 42-style layout.sim.qrc resolves the runtime image via aliases derived from the keymap file's basename (
42style.png,legacy.png, ...), so the wrong image was loaded for both maps — selectingconfig/42style.48krendered the legacy face, and selectingconfig/legacy.48krendered the 42-style face.Swap the file contents in place so the qrc aliases (unchanged) now resolve correctly:
42style.png-> 42-style face,legacy.png-> older db48x face.Forum report:
https://www.hpmuseum.org/forum/thread-20157-post-217541.html#pid217541
Note that is was not investigated, if the legacy face is the historically correct one, but with corrected yellow alpha character (sigma instead of rho). But it was seen that it seems to render like the newer standard db48 face.