Skip to content

docs: code review snapshot of master @ 114f89a#66

Open
upsetbit wants to merge 1 commit into
masterfrom
docs/code-review-master
Open

docs: code review snapshot of master @ 114f89a#66
upsetbit wants to merge 1 commit into
masterfrom
docs/code-review-master

Conversation

@upsetbit
Copy link
Copy Markdown
Contributor

@upsetbit upsetbit commented Jun 5, 2026

Summary

  • 8 parallel reviewer agents covered go idioms, security, importers, store, cli, panel/server, testing, and architecture.
  • Each report carries severity-ranked findings with file:line citations and concrete fixes (~26k words total).
  • review/README.md indexes cross-cutting headlines where multiple reviewers converged, plus a Top-10 actions-by-ROI list.

Cross-cutting headlines

  1. Fakes mascarando contrato de produçãoinMemSink em 5 dos 6 importers ainda não implementa SkipCache; mesmo padrão que produziu o bug de FK no commit 114f89a.
  2. Path traversal via session ID controlado por atacantefilepath.Join(rawRoot, sessionID+ext) aceita IDs vindos de JSONL/SQLite externos.
  3. Analytics bifurcado entre internal/store/analytics.go (SQLite) e internal/server/handlers/analytics.go (Postgres), com shapes divergentes mascarados por normalizeRemoteAnalyticsResult.
  4. CSRF + security headers ausentes no panel.
  5. internal/cli/sync.go virou orquestrador de 701 linhas com 5 responsabilidades misturadas.

Posture saudável (calibração)

  • Boundaries pkg/internal/binaries respeitadas (sem critical em arquitetura).
  • SQL parametrizado em todo lugar; FTS5 bound; PKCE/state/sha256; html/template + goldmark com unsafe desligado.
  • 260 sites de fmt.Errorf("...: %w", ...); vet limpo; zero //nolint.
  • Disciplina de ProjectionVersion v6→v7→v8 elogiada como exemplar.
  • gen/ limpo; migration ownership clean.

Intent

Este PR não é documentação durável do prosa — é um audit point-in-time
no 114f89a. Os achados devem virar issues/PRs separados. Considerar
deletar review/ ou movê-lo para docs/reviews/2026-06-05/ antes de
mergear, dependendo de como você quer tratar relatórios de auditoria.

Test plan

  • markdownlint-cli2 --fix aplicado em todos os arquivos
  • Pre-commit hooks passaram (markdownlint, gitleaks, commitlint)
  • Pre-push gate passou (lint-links, agnix, gitleaks, npm-check)
  • Reviewer humano para decidir se o conteúdo vira issues/PRs e onde os reviews ficam guardados

🤖 Generated with Claude Code


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Multi-agent review across 8 dimensions (go idioms, security, importers,
store, cli, panel/server, testing, architecture). Each report carries
severity-ranked findings with file:line citations and concrete fixes.
README.md indexes cross-cutting headlines where reviewers converged.

Intended as a point-in-time audit to drive action items, not durable
prosa documentation — see review/README.md "Top-10 ações por ROI" for
the prioritized followups.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant