docs: code review snapshot of master @ 114f89a#66
Open
upsetbit wants to merge 1 commit into
Open
Conversation
Multi-agent review across 8 dimensions (go idioms, security, importers, store, cli, panel/server, testing, architecture). Each report carries severity-ranked findings with file:line citations and concrete fixes. README.md indexes cross-cutting headlines where reviewers converged. Intended as a point-in-time audit to drive action items, not durable prosa documentation — see review/README.md "Top-10 ações por ROI" for the prioritized followups. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file:linecitations and concrete fixes (~26k words total).review/README.mdindexes cross-cutting headlines where multiple reviewers converged, plus a Top-10 actions-by-ROI list.Cross-cutting headlines
inMemSinkem 5 dos 6 importers ainda não implementaSkipCache; mesmo padrão que produziu o bug de FK no commit114f89a.filepath.Join(rawRoot, sessionID+ext)aceita IDs vindos de JSONL/SQLite externos.internal/store/analytics.go(SQLite) einternal/server/handlers/analytics.go(Postgres), com shapes divergentes mascarados pornormalizeRemoteAnalyticsResult.internal/cli/sync.govirou orquestrador de 701 linhas com 5 responsabilidades misturadas.Posture saudável (calibração)
pkg/internal/binaries respeitadas (sem critical em arquitetura).html/template+ goldmark com unsafe desligado.fmt.Errorf("...: %w", ...); vet limpo; zero//nolint.ProjectionVersionv6→v7→v8 elogiada como exemplar.gen/limpo; migration ownership clean.Intent
Este PR não é documentação durável do prosa — é um audit point-in-time
no
114f89a. Os achados devem virar issues/PRs separados. Considerardeletar
review/ou movê-lo paradocs/reviews/2026-06-05/antes demergear, dependendo de como você quer tratar relatórios de auditoria.
Test plan
markdownlint-cli2 --fixaplicado em todos os arquivos🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.