Skip to content

test(importers): lock shared sink skip cache#210

Merged
upsetbit merged 1 commit into
masterfrom
codex/issue-77-importertest-skipcache
Jun 6, 2026
Merged

test(importers): lock shared sink skip cache#210
upsetbit merged 1 commit into
masterfrom
codex/issue-77-importertest-skipcache

Conversation

@upsetbit
Copy link
Copy Markdown
Contributor

@upsetbit upsetbit commented Jun 6, 2026

Closes #77.

Summary

  • add compile-time assertions that importertest.Sink implements importer.Sink and importer.SkipCache
  • cover skip cache storage by session id and reason so importer tests keep exercising no_usage/state_seen idempotency

Local validation

  • go test ./internal/importers/... -race
  • devbox run -- just lint
  • devbox run -- just test-race

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@upsetbit upsetbit merged commit 0f24292 into master Jun 6, 2026
5 checks passed
@upsetbit upsetbit deleted the codex/issue-77-importertest-skipcache branch June 6, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promote inMemSink with SkipCache to a shared importer test helper

1 participant