Skip to content

Harden SSE notification loop#205

Merged
upsetbit merged 1 commit into
masterfrom
codex/issue-95-sse-channels
Jun 6, 2026
Merged

Harden SSE notification loop#205
upsetbit merged 1 commit into
masterfrom
codex/issue-95-sse-channels

Conversation

@upsetbit
Copy link
Copy Markdown
Contributor

@upsetbit upsetbit commented Jun 6, 2026

Closes #95.

Summary

  • buffer the SSE notification event channel to avoid blocking the producer on every consumer tick
  • preserve and log WaitForNotification errors when they are not normal context cancellation
  • guard nil notifications before reading the payload

Local validation

  • go test ./internal/server/handlers ./internal/server
  • devbox run -- just lint
  • just test-race

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@upsetbit upsetbit merged commit 25443ea into master Jun 6, 2026
5 checks passed
@upsetbit upsetbit deleted the codex/issue-95-sse-channels branch June 6, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harden SSE notification goroutine error and event channels

1 participant