test(integration): add benign hard negatives to the adversarial corpus - #72
Open
VibhorGautam wants to merge 1 commit into
Open
test(integration): add benign hard negatives to the adversarial corpus#72VibhorGautam wants to merge 1 commit into
VibhorGautam wants to merge 1 commit into
Conversation
ap-109 to ap-124 from Kavishka's false positive review. 9 pass today and pin current behaviour, 4 of those are canaries for the exact chars the ap-097/098 fix wants to add. the other 7 are real false positives tracked as open gap probes, same pattern as the attack side gaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds 16 benign hard negatives (ap-109 to ap-124) that Kavishka put together while reproducing the detection numbers. these measure the false positive side that the corpus never covered, we only ever counted catch rate
split into 2 groups, same convention the corpus already uses:
corpus only, no code or policy changes. full integration suite green locally with -count=1, 9 strict cases pass, 7 gaps register as open. authored by Kavishka, landed verbatim