Memory cleanups - #9
Open
treveradams wants to merge 1 commit into
Open
Conversation
treveradams
force-pushed
the
memory-cleanups
branch
from
August 13, 2020 14:20
673ea31 to
21090b8
Compare
treveradams
force-pushed
the
memory-cleanups
branch
from
August 13, 2020 14:21
21090b8 to
02c1c66
Compare
chtsanti
requested changes
Sep 19, 2020
| ci_list_destroy(service_extra_data_list[i].option_handlers); | ||
| service_extra_data_list[i].option_handlers = NULL; | ||
| } | ||
| free(service_data(service_list[i])); |
Contributor
There was a problem hiding this comment.
This is does not looks correct. The service_data function will return a pointer to an item of the service_extra_data_list array. This item is not an allocated memory block.
In the other hand the service_extra_data_list array needs to be released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, these are only on shutdown. However, I do think it is best to be clean.