Add custom data setter for InstantiationArgs2#4936
Merged
lum1n0us merged 1 commit intoMay 25, 2026
Conversation
mechakotik
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
Add custom data setter for InsantiationArgs2, so user can provide custom data before post-instantiation code (such as _initialize) runs.
mechakotik
force-pushed
the
instantiate-custom-data
branch
from
73fb140 to
9f48c2d
Compare
lum1n0us
approved these changes
May 12, 2026
Contributor
Author
|
Just pinging in case this PR got lost. Anything I should address to move it forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom data setter for InsantiationArgs2, so user can provide custom data before post-instantiation code (such as
_initialize) runs.