Fix multi-value operator result order.#16
Merged
Conversation
The localification (regalloc and local.get/local.set insertion) pass previously handled multi-value operators with results in the incorrect (reversed) order. This hadn't been caught yet as multi-value results had apparently not yet been used in a nontrivial use-case nor hit by a fuzzer. This PR fixes the order and adds a roundtrip test (the idempotency/fixpoint condition of the roundtrip test will fail if the results are reversed as they will flip on each roundtrip).
Merged
fitzgen
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The localification (regalloc and local.get/local.set insertion) pass previously handled multi-value operators with results in the incorrect (reversed) order. This hadn't been caught yet as multi-value results had apparently not yet been used in a nontrivial use-case nor hit by a fuzzer. This PR fixes the order and adds a roundtrip test (the idempotency/fixpoint condition of the roundtrip test will fail if the results are reversed as they will flip on each roundtrip).