Fix issue of trying to create new PDFs in preexisting directory. - #2
Open
dustin-lennon wants to merge 26 commits into
Open
Fix issue of trying to create new PDFs in preexisting directory.#2dustin-lennon wants to merge 26 commits into
dustin-lennon wants to merge 26 commits into
Conversation
Update index.js, pdfGenerator.js, and README.md file to use and explain how to pass additional parameters to pdftk command
Pass addtional parameters to pdftk application
Remove console.logs used for debugging purposes
Save file fix
Contributor
|
@deejayres @sdiachenko @B-3PO Some additonal pr's from people using this library. May help, please see if this will cause any breaking changes. |
txssseal
reviewed
Mar 13, 2018
|
|
||
| console.log('Files: ', files); | ||
| console.log('PDFtk Options: ', pdftkOptions); | ||
| console.log('Function test: ', convertObjString(pdftkOptions)); |
Contributor
There was a problem hiding this comment.
can we get rid of the console logs?
txssseal
reviewed
Mar 15, 2018
| console.error(err) | ||
| return; | ||
| } | ||
| // Check if directory being written to already exists |
txssseal
reviewed
Mar 15, 2018
| var pexec = Promise.promisify(exec); | ||
|
|
||
| module.exports = function generatePDF(options, templates, fileName, pdftkPath) { | ||
| module.exports = function generatePDF(options, templates, fileName, pdftkPath, pdftkOptions) { |
Contributor
There was a problem hiding this comment.
@absalas in some of your changes you will need to take into account his new changes
Contributor
There was a problem hiding this comment.
specifically passing in the whole options object
|
Heyo, we're in the middle of the process of deploying features that depend on this, and are trying to minimize the moving parts until we can flex on this in prod. Honestly had no idea this was an open repo. We can keep the PR open, but it might be a while before we can approve. |
The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-450202
…bf4579e17f5b8 [Snyk] Fix for 1 vulnerable dependencies
The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-450202
…e2ec803451aab [Snyk] Fix for 1 vulnerable dependencies
|
Any ETA when will this be merged? |
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-UGLIFYJS-1727251
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-HTMLPDF-467248
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-EJS-6689533
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-PUGCODEGEN-7086056
…933ca6dd945830 [Snyk] Security upgrade pug from 2.0.4 to 3.0.0
…f9a1e42bae1eea [Snyk] Security upgrade ejs from 2.7.4 to 3.1.10
…eab14c0080e9fe [Snyk] Security upgrade html-pdf from 2.2.0 to 3.0.1
…584e1f5e733198 [Snyk] Security upgrade pug from 2.0.4 to 3.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDFs would fail to be created due to save directory already existing and current code cannot do a make directory with a folder of the same name. Pull request checks if directory exists and if it does not creates the directory and does the save to the directory. If the directory does exist, saves the PDF to the directory.