feat(cli): add --shell flag to sbx attach#20
Merged
Conversation
Allow users to specify a custom shell (e.g. /bin/zsh) when attaching to a sandbox PTY session. Uses flag.FlagSet for proper argument parsing.
The expose probe consumes one nc iteration, and nc needs time to restart in the while loop. TestPortProxy and TestPortsCleanedOnDestroy now retry like TestExposeAndClosePort already does.
ch99q
force-pushed
the
ch99q/add-sbx-shell-cmd
branch
from
3150316 to
c2f8ff0
Compare
The "no daemon" test group used a bare client.connect() without retry, causing timeouts in CI when the MCP server process was slow to start.
WriteFrame previously used two separate Write calls (header, then payload), allowing concurrent goroutines to interleave partial frames and corrupt the stream. Combine into a single Write for atomicity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--shellflag tosbx attachso users can specify a custom shell (e.g./bin/zsh) for PTY sessionsflag.FlagSetfor proper argument parsing instead of raw positional argsTest plan
sbx attach <id>still works with default shellsbx attach --shell /bin/zsh <id>launches zshsbx attachwith no args prints updated usage