Skip to content

Stop goroutine when audio is done playing. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omatztw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop goroutine when audio is done playing. #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions dgvoice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,17 @@ func PlayAudioFile(v *discordgo.VoiceConnection, filename string, stop <-chan bo
// prevent memory leak from residual ffmpeg streams
defer run.Process.Kill()

// Stop goroutine when audio is done playing
done := make(chan struct{})
defer close(done)

//when stop is sent, kill ffmpeg
go func() {
<-stop
err = run.Process.Kill()
select {
case <-stop:
err = run.Process.Kill()
case <-done:
}
}()

// Send "speaking" packet over the voice websocket
Expand Down