Skip to content

feat: add email notifications for review comments - #16

Merged
NagariaHussain merged 1 commit into
developfrom
fix/email-notifications-on-comments
Feb 11, 2026
Merged

feat: add email notifications for review comments#16
NagariaHussain merged 1 commit into
developfrom
fix/email-notifications-on-comments

Conversation

@NagariaHussain

Copy link
Copy Markdown
Contributor

Summary

  • Notify the asset uploader when someone else comments on their upload
  • Notify the parent comment author when someone replies to their comment
  • Emails sent via background job (frappe.enqueue) to avoid blocking the API response
  • Self-notifications are skipped (commenter == uploader or commenter == parent author)

Implementation

  • New vms/notifications.py with send_comment_notification (hook) and _send_comment_email (worker)
  • Wired via doc_events in hooks.py on VMS Review Comment.after_insert

Test plan

  • Comment on asset where uploader is a different user → email queued and sent
  • Reply to another user's comment → email queued and sent
  • Comment on own upload → no email sent (self-notification skipped)
  • Reply to own comment → no email sent
  • Verified via Email Queue list view — all test emails show status "Sent"

Closes #3

🤖 Generated with Claude Code

Notify the asset uploader when someone else comments on their upload,
and notify the parent comment author when someone replies to their
comment. Emails are sent via background job to avoid blocking the API.

Closes #3

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@NagariaHussain
NagariaHussain merged commit 0388f5c into develop Feb 11, 2026
4 checks passed
@NagariaHussain
NagariaHussain deleted the fix/email-notifications-on-comments branch February 11, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email notifications using frappe.sendmail

1 participant