Skip to content

fix: align navbar borders and remove orphan separator #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagariaHussain merged 2 commits into from
Feb 11, 2026
Merged

fix: align navbar borders and remove orphan separator #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee4263f
fix: align navbar borders and remove orphan separator
NagariaHussain Feb 11, 2026
713d013
style: apply ruff formatting to api.py
NagariaHussain Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions frontend/src/components/layout/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { useFrappeAuth } from "frappe-react-sdk"
import { HugeiconsIcon } from "@hugeicons/react"
import { CloudUploadIcon, LogoutIcon, UserCircleIcon } from "@hugeicons/core-free-icons"
import { Button } from "@/components/ui/button"
import { Separator } from "@/components/ui/separator"
import { SidebarTrigger } from "@/components/ui/sidebar"
import { UploadDialog } from "@/components/UploadDialog"
import { ModeToggle } from "@/components/mode-toggle"
Expand All @@ -23,10 +22,6 @@ export function Header() {
<header className="flex h-14 shrink-0 items-center justify-between border-b border-border bg-background px-4 md:px-6">
<div className="flex items-center gap-2">
<SidebarTrigger className="-ml-1" />
<Separator
orientation="vertical"
className="mr-2 hidden md:block data-[orientation=vertical]:h-4"
/>
</div>
<div className="flex items-center gap-3">
<Button variant="outline" size="sm" onClick={() => setUploadOpen(true)}>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/layout/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function AppSidebar({ onOpenSettings }: { onOpenSettings: () => void }) {

return (
<Sidebar>
<SidebarHeader className="border-b border-sidebar-border px-4 py-3">
<SidebarHeader className="h-14 shrink-0 flex-row items-center border-b border-sidebar-border px-4">
<span className="text-lg font-bold text-sidebar-foreground">VMS</span>
</SidebarHeader>
<SidebarContent>
Expand Down
7 changes: 6 additions & 1 deletion vms/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,12 @@ def rename_asset(asset_name: str, new_file_name: str):
file_size=asset.file_size,
)

return {"status": "ok", "asset_name": asset.name, "old_file_name": old_file_name, "new_file_name": new_file_name}
return {
"status": "ok",
"asset_name": asset.name,
"old_file_name": old_file_name,
"new_file_name": new_file_name,
}


@frappe.whitelist()
Expand Down
4 changes: 2 additions & 2 deletions vms/public/frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<link rel="icon" type="image/svg+xml" href="/assets/vms/frontend/vms-logo.png" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>BWH VMS</title>
<script type="module" crossorigin src="/assets/vms/frontend/assets/index-PNh42eIs.js"></script>
<link rel="stylesheet" crossorigin href="/assets/vms/frontend/assets/index-CqKX5av-.css">
<script type="module" crossorigin src="/assets/vms/frontend/assets/index-Du5eT9YR.js"></script>
<link rel="stylesheet" crossorigin href="/assets/vms/frontend/assets/index-VQ8vvVbA.css">
</head>
<body>
<div id="root"></div>
Expand Down
4 changes: 2 additions & 2 deletions vms/www/vms.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<link rel="icon" type="image/svg+xml" href="/assets/vms/frontend/vms-logo.png" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>BWH VMS</title>
<script type="module" crossorigin src="/assets/vms/frontend/assets/index-PNh42eIs.js"></script>
<link rel="stylesheet" crossorigin href="/assets/vms/frontend/assets/index-CqKX5av-.css">
<script type="module" crossorigin src="/assets/vms/frontend/assets/index-Du5eT9YR.js"></script>
<link rel="stylesheet" crossorigin href="/assets/vms/frontend/assets/index-VQ8vvVbA.css">
</head>
<body>
<div id="root"></div>
Expand Down
Loading