You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The submitForm function in the submission form store was refactored to accept an additional ignore_validations parameter, enabling draft saves to bypass form validations. The isDraft parameter was renamed to is_draft for consistency.
Changes
Cohort / File(s)
Summary
Submission Form Store frontend/src/stores/submissionForm.ts
Updated submitForm method signature to accept ignore_validations boolean parameter; refactored validation logic to conditionally apply based on this parameter; renamed isDraft to is_draft throughout function body and onSuccess handler; modified saveAsDraft call to pass (true, true) arguments to bypass validations when saving drafts
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
🐰 A form that submits with grace,
Draft or final, the parameters race,
Validations skip when drafts take flight,
Parameter names now shiny and bright! ✨
✨ Finishing touches
📝 Generate docstrings
📜 Recent review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 946d0d7 and c72a248.
📒 Files selected for processing (1)
frontend/src/stores/submissionForm.ts
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.