Skip to content

ci: keep backport PR titles conventional - #291

Merged
harshtandiya merged 1 commit into
developfrom
fix/backport-pr-title-lint
Jul 26, 2026
Merged

ci: keep backport PR titles conventional#291
harshtandiya merged 1 commit into
developfrom
fix/backport-pr-title-lint

Conversation

@harshtandiya

Copy link
Copy Markdown
Collaborator

Problem

backport.yml set:

pull_title: '[Backport ${target_branch}] ${pull_title}'

The prefix pushes the conventional-commit type out of first position, so amannn/action-semantic-pull-request in PR Title Check cannot parse it. Every generated backport PR failed the check and needed a manual retitle.

Fix

  • pull_title: '${pull_title}' — reuse the source title verbatim. It is already conventional (the source PR passed the same check).
  • add_labels: backport — the label carries the "this is a backport" signal that the title prefix used to. The backport label already exists in this repo.

This matches upstream frappe, which uses title: "{{originalTitle}}" plus labelsToAdd: "backport".

Notes

  • backport (no space) does not match label_pattern: '^backport ([^ ]+)$', so labelling the generated PR cannot re-trigger the workflow.
  • Target branch is still visible in the PR body (Automated backport of #N to \branch``) and in the generated branch name.

🤖 Generated with Claude Code

The "[Backport <branch>] " prefix pushed the conventional-commit type out
of first position, so every generated backport PR failed PR Title Check.
Reuse the source title verbatim and tag the PR with the "backport" label
instead, matching frappe's backport workflow.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harshtandiya has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@harshtandiya harshtandiya added the backport main backport to main branch label Jul 26, 2026
@harshtandiya
harshtandiya merged commit 7094813 into develop Jul 26, 2026
7 checks passed
@harshtandiya
harshtandiya deleted the fix/backport-pr-title-lint branch July 26, 2026 19:37
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed for main, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin main
git worktree add -d .worktree/backport-291-to-main origin/main
cd .worktree/backport-291-to-main
git switch --create backport-291-to-main
git cherry-pick -x 7094813c5cb097476272069d6b308ac7f89ff863

harshtandiya added a commit that referenced this pull request Jul 29, 2026
Brings main to parity with develop at a4f52b2: the buzz/api domain package
split (#295-#303), the shared bench setup action (#305), and the backport
workflow (#273, #291). Tree is identical to develop at a4f52b2.
harshtandiya added a commit that referenced this pull request Jul 29, 2026
Brings main to parity with develop at a4f52b2: the buzz/api domain package
split (#295-#303), the shared bench setup action (#305), and the backport
workflow (#273, #291). Tree is identical to develop at a4f52b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport main backport to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant