feat: Guest booking with email/phone OTP - #137
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Let’s make both SMS and Email OTP options available to the user (they can also set it to No OTP verification btw). There is a PR somewhere in Framework repo by Bhushan to add generic phone OTP feature, from which we can borrow the code. |
|
Without OTP:
|
|
Let the event organisers decide. If someone is paying, they will enter their real email ID. If not the event organisers can turn it on. |
|
Let's add some e2e test @UmakanthKaspa All the three scenarios:
You can use some flag in backend to return some hardcoded OTPs. |
|
@UmakanthKaspa please add videos and relevant screenshots. |
|
@NagariaHussain added |
…ass, name validation)
- use route meta for public page access - rename isGuestMode to isGuest - remove what comments, keep why comments - fix test to use assertRaises
|
Commits are no longer conventional 😅 Let's maintain the convention. |
8dfecfb to
cb82eb7
Compare
@vishwajeet-13 Good catch! Will auto-fill Attendee 1 from guest details — they can edit if booking for someone else 👍 |
Screen.Recording.2026-01-30.at.8.20.54.PM.mov |
|
Can you add this case in the e2e test please? |
|
@NagariaHussain added |
b899d57 to
5e6710e
Compare
|
Why maintain two config keys? in_test and allow_tests? Let's make "in_test" work (toggle before running UI tests too, check how it is toggled for unit tests) everywhere both in UI and unit tests. |
|
Always look in Frappe code for patterns before reinventing them 😉 |
6af4d64 to
5118a99
Compare
|
@NagariaHussain I tried bench execute toggle_test_mode - doesn't work before or after server start. Why: bench execute runs in separate process. When bench start runs, those flags are lost. Fix: We need either env var or site config. Currently using CI env var. Can switch to allow_tests if you Did I miss anything? Let me know your thoughts. |
|
Hello @UmakanthKaspa |




closes: #89
Summary
Let guests book tickets without logging in. Event organizers can turn this on per event and pick how
to verify the guest: no check, email code, or phone code.
What changed
Email OTP / Phone OTP)
a real owner
not the full event doc
link
How to test
missing email, and lockout after too many tries
e2e_test_modeso code endpoints return the code in the response instead of sending realemails/SMS
##Demo
Screen.Recording.2026-01-27.at.9.53.06.PM.mov
Screen.Recording.2026-01-27.at.9.59.53.PM.mov