Handle Everdrive header offset in libflashcart when receiving data > 504 bytes#141
Merged
Merged
Conversation
Owner
|
Seems to all be building and working. Thanks for the PR! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #140, this accounts for the header bytes in the first chunk when receiving messages larger than 504 bytes from Everdrives. Subsequent loops for large messages read the full 512 byte chunk size.
Related Issue
#140
Motivation and Context
Fixes #140. Reading from Everdrive for messages larger than 504 bytes would always fail with error
DEVICEERR_READFAIL. To isolate the specific cause in the function, as there were multiple locations this could be thrown, I modified the error codes in an offline branch. This pointed to the call in the while loop reading the main payload.How Has This Been Tested?
Tested on both X7 and V3 Everdrives on OS 3.10 and 3.06, respectively, with the library's protocol set to V2. I'm using the library in my own client at
https://github.com/mracsys/n64usb
with the randomizer branch
https://github.com/mracsys/OoT-Randomizer/tree/summercart_mw_support
Screenshots (if appropriate):
N/A