Customisation with options#14
Open
domchristie wants to merge 1 commit into
Open
Conversation
Contributor
|
@domchristie OK, sat with this a bit and I think this gets merged. Give me a little bit to find some time to really play with it. I have a couple ideas for syntactic sugar here that might be nice. |
Contributor
Author
|
Cool. I'm still having a play with it myself (in combination with #9). I'll hopefully be able to detail a real use case soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
This pull request adds a simple customisation enhancement. It allows Nice Partials to provide a default options object to the parent view via
np, and made accesible fromp.options. This can be modified by the parent view as needed, effectively allowing it to "reach in" and modify the internals of the partial for a given case.For example, classes can be modified for that occasional case that needs different: in this case, adding
rounded-noneand removingrounded:What's happening here?
rounded-noneas a local, then deletes theroundedclassoptions[:class]usingtoken_listin Rails 6.1