feat: add getTotalAmountDue and multicall batching for view commands - #13
Merged
Conversation
- Add getTotalAmountDue ABI + view command for invoices - Change all view commands from --claim-id to --claim-ids (comma-separated) - Implement batch reader methods using viem multicall for single-RPC lookups - Add formatViewResults for multi-result output
bengobeil
commented
Apr 8, 2026
getTotalAmountDue is self-sufficient — no need to fetch the full loan just to validate existence. Also adds a total-due e2e test after accepting a loan offer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
solidoracle
approved these changes
Apr 9, 2026
Contributor
Author
|
🎉 This PR is included in version 0.0.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTotalAmountDueABI entry andinvoice total-dueview command--claim-id(singular) to--claim-ids(comma-separated) for batch lookupsmulticall()— all claim IDs are resolved in a single RPC call via Multicall3formatViewResultsfor multi-result output (JSON array / human-readable blocks)Commands updated
invoice get,invoice deposit-needed,invoice total-duefrendlend get-loan,frendlend total-dueTest plan
npx tsc --noEmitpasses--claim-idsflagbulla invoice total-due --claim-ids 1,2,3 --rpc-url ... --chain ...returns batched results🤖 Generated with Claude Code