Skip to content

fix: correct auth getMessage endpoint to /message #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bengobeil merged 4 commits into from
Mar 19, 2026
Merged

fix: correct auth getMessage endpoint to /message #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afa23bb
fix: correct auth getMessage endpoint to /message
bengobeil Mar 19, 2026
fa9efcc
fix: use correct /message/{wallet} endpoint path
bengobeil Mar 19, 2026
b4b59d8
fix: use correct /verify/{wallet} endpoint path
bengobeil Mar 19, 2026
847c7b2
fix: update wallet extraction regex in mock server to match /verify/{…
bengobeil Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/application/ports/backend-client-port.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ import type {
* Covers authentication, underwriting, and tap-credit flows.
*/
export interface BackendClientService {
/** GET /auth/{wallet}/getMessage — fetch SIWE challenge message. */
/** GET /message/{wallet} — fetch SIWE challenge message. */
readonly getMessage: (wallet: string) => Effect.Effect<GetMessageResponse, Error>;

/** POST /auth/{wallet}/verifyMessage — submit signed message and receive JWT. */
/** POST /verify/{wallet} — submit signed message and receive JWT. */
readonly verifyMessage: (wallet: string, signature: string) => Effect.Effect<VerifyMessageResponse, Error>;

/** POST /underwrite/{wallet}/chain/{chainId}/pool/{poolAddress} — underwrite claims. */
Expand Down
4 changes: 2 additions & 2 deletions src/infrastructure/http/backend-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ const fetchJson = <T>(url: string, init?: RequestInit): Effect.Effect<T, Error>

export const BackendClientLive = Layer.succeed(BackendClientService, {
getMessage: (wallet: string) =>
fetchJson<GetMessageResponse>(`${AUTH_BASE_URL}/auth/${wallet}/getMessage`),
fetchJson<GetMessageResponse>(`${AUTH_BASE_URL}/message/${wallet}`),

verifyMessage: (wallet: string, signature: string) =>
fetchJson<VerifyMessageResponse>(`${AUTH_BASE_URL}/auth/${wallet}/verifyMessage`, {
fetchJson<VerifyMessageResponse>(`${AUTH_BASE_URL}/verify/${wallet}`, {
method: 'POST',
headers: { 'Content-Type': 'text/plain' },
body: signature,
Expand Down
10 changes: 5 additions & 5 deletions test/cli/factoring/backend-commands.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,17 @@ const handleRequest = async (req: IncomingMessage, res: ServerResponse) => {
const url = req.url ?? '';
const method = req.method ?? 'GET';

// GET /auth/{wallet}/getMessage
if (method === 'GET' && url.match(/^\/auth\/0x[0-9a-fA-F]+\/getMessage$/)) {
// GET /message/{wallet}
if (method === 'GET' && url.match(/^\/message\/0x[0-9a-fA-F]+$/)) {
res.writeHead(200, { 'Content-Type': 'application/json' });
res.end(JSON.stringify({ message: SIWE_MESSAGE }));
return;
}

// POST /auth/{wallet}/verifyMessage
if (method === 'POST' && url.match(/^\/auth\/0x[0-9a-fA-F]+\/verifyMessage$/)) {
// POST /verify/{wallet}
if (method === 'POST' && url.match(/^\/verify\/0x[0-9a-fA-F]+$/)) {
const signature = await readBody(req);
const walletMatch = url.match(/\/auth\/(0x[0-9a-fA-F]+)\//);
const walletMatch = url.match(/\/verify\/(0x[0-9a-fA-F]+)$/);
const wallet = walletMatch?.[1] ?? '';

// Actually verify the SIWE signature
Expand Down
Loading