Add timestamp.valid evaluator#85
Closed
simonbos wants to merge 1 commit into
Closed
Conversation
Contributor
|
hi @simonbos, going to close this out for the time being as the upstream issue has stalled and there's a good number of conflicts to resolve. Feel free to reopen if you end up wanting to push this forward! |
Author
|
That's fine for me! In recent projects I didn't need this anymore, so I won't reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bufbuild/protovalidate#101 for details.
This depends on bufbuild/protovalidate#114 being merged. However, locally I was able to build & run conformance tests using some edits to the
Makefile. (After the merge on the main repo, I would best re-generate the generated stubs.)Note that these changes also fix an
OverflowErrorbug when convertingmessage.Messagetoceltypes.TimestampType.