Skip to content

Llm/integration tests fixes#480

Merged
Thirunayan22 merged 7 commits into
buerokratt:wipfrom
rootcodelabs:llm/integration-tests-fixes
Jun 19, 2026
Merged

Llm/integration tests fixes#480
Thirunayan22 merged 7 commits into
buerokratt:wipfrom
rootcodelabs:llm/integration-tests-fixes

Conversation

@nuwangeek

Copy link
Copy Markdown
Collaborator

This pull request refactors how integration tests handle Vault secrets and connection IDs for LLM and embedding models. The changes ensure that test secrets, database rows, and API requests all use a single, deterministic vault_uuid value. This removes previous mismatches and makes the test environment more robust and less dependent on database-assigned IDs. Additionally, the Vault token and file system mounts in the test Docker Compose setup are updated for consistency.

Key changes:

Secret management and test consistency

  • All LLM and embedding Vault secrets for integration tests now use a fixed TEST_VAULT_UUID instead of environment-based or database-generated IDs, ensuring that secrets, DB rows, and API requests are aligned. (tests/integration_tests/conftest.py, DSL/Ruuter.private/rag-search/POST/inference/test.yml, [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • The integration test setup forcibly updates the vault_uuid field in the relevant test database row to match TEST_VAULT_UUID by introducing a new _pin_vault_uuid helper. (tests/integration_tests/conftest.py, [1] [2]

Docker Compose test environment improvements

  • Docker Compose mounts for the Vault agent and LLM orchestrator are updated so that the Vault token is consistently accessible at /agent/llm-token/token, matching the default expectation of the code. (docker-compose-test.yml, [1] [2]

Model and API changes

  • The connectionId field in the test request model is changed from Optional[int] to Optional[str] to reflect the use of UUIDs instead of integer IDs. (src/models/request_models.py, src/models/request_models.pyL272-R274)

Miscellaneous

@nuwangeek nuwangeek requested a review from Thirunayan22 June 19, 2026 06:49
@nuwangeek nuwangeek linked an issue Jun 19, 2026 that may be closed by this pull request
@Thirunayan22 Thirunayan22 merged commit d2f8d8a into buerokratt:wip Jun 19, 2026
6 of 7 checks passed
nuwangeek added a commit to rootcodelabs/LLM-Module that referenced this pull request Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix issues in integration tests issues

2 participants