[WIP] btcutil: Add library functions for BIP-0352 silent payment _scan_ support#2466
Draft
guggero wants to merge 10 commits into
Draft
[WIP] btcutil: Add library functions for BIP-0352 silent payment _scan_ support#2466guggero wants to merge 10 commits into
guggero wants to merge 10 commits into
Conversation
guggero
force-pushed
the
silent-payments-receive
branch
from
415da0a to
aab6396
Compare
Fixes an independent issue discovered while reviewing and testing the code that failed to detect duplicate xPubs because the wrong variable (keyData holding the nil value of the global unsigned TX, instead of the lowercase keydata that's the loop variable).
This commit adds library functions for calculating block tweaks. A block tweak is the set of Silent Payment transaction tweaks that are contained in a block. A SP transaction tweak is the pre-calculated input public key sum tweaked by the input hash of a transaction and is required for light clients to be able to calculate potential Silent Payment outputs in a transaction or block without needing to download the full block/transaction.
This commit adds helper functions that can be used by clients (including light clients) to scan the chain for potential Silent Payment outputs.
guggero
force-pushed
the
silent-payments-receive
branch
from
aab6396 to
afaa92a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2244, only the last two commits are new.
This is still very much work in progress.