Skip to content
This repository was archived by the owner on Jun 12, 2026. It is now read-only.

Fix/recovery flow - #144

Merged
BraydenLangley merged 2 commits into
masterfrom
fix/recovery-flow
Apr 7, 2026
Merged

Fix/recovery flow#144
BraydenLangley merged 2 commits into
masterfrom
fix/recovery-flow

Conversation

@BraydenLangley

@BraydenLangley BraydenLangley commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Description of Changes

  • Fix provideRecoveryKey guard blocking recovery-key-and-password mode
  • Set authenticationFlow to existing-user after recovery key token lookup

This fixes the recovery flow so that wallets don't need to override managers.walletManager!.authenticationFlow value manually.

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run npm run doc and npm run lint one final time before requesting a review
  • I have run npm version patch so that my changes will trigger a new version to be released when they are merged

@sonarqubecloud

sonarqubecloud Bot commented Apr 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
22.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@raspi-user

Copy link
Copy Markdown
Collaborator

Successfully tested on Ubuntu:

image

@raspi-user raspi-user left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - see main comment.

@raspi-user

Copy link
Copy Markdown
Collaborator

Clarification: I tested v0.6.62 downloaded from getmetanet.com

@BraydenLangley
BraydenLangley merged commit 1b156c3 into master Apr 7, 2026
7 of 8 checks passed
@BraydenLangley
BraydenLangley deleted the fix/recovery-flow branch April 7, 2026 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants