[codex] Remove wallet request timeout - #54
Merged
Conversation
ty-everett
marked this pull request as ready for review
June 22, 2026 23:36
sirdeggen
previously requested changes
Jul 9, 2026
Keep permission-gated wallet requests open while the session is healthy, but settle pendingRequests when the HTTP client disconnects, the renderer crashes/reloads, the window closes, or the HTTP server shuts down.
Track in-flight HTTP bridge sessions by originator, notify the renderer on client disconnect, and deny/remove matching permission queue entries so modals do not remain after the caller is gone.
Resolve conflicts by keeping vault lock gating from master, the HTTP bridge disconnect/lifecycle cleanup from this branch, and package version 2.6.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A visible wallet prompt is a legitimate pending state. Apps should not receive synthetic timeout failures while the user is still deciding.
Validation