Bugfix: fix GEMDigiProducer not using new-style GEMDetId#14
Open
watson-ij wants to merge 8 commits into
Open
Conversation
Owner
|
Thanks James |
Owner
|
Thank you Ian,
Sunanda
…________________________________
From: Ian J. Watson [notifications@github.com]
Sent: 23 May 2019 13:36
To: bsunanda/cmssw
Cc: Subscribed
Subject: [bsunanda/cmssw] Bugfix: fix GEMDigiProducer not using new-style GEMDetId (#14)
Hi Sunanda, I've been looking into the issues from Slava, and I found that the GEMDigiProducer was using directly the rawId when gathering simHits, causing it to not associate hits with the old id to the eta partitions of GEM, which are built with the newId. This should fix this, which resolves the "backward compatibility". That is, it should solve the missing digis problem but it doesn't change the station() plots though, which seems a separate issue.
________________________________
You can view, comment on, or merge this pull request online at:
#14
Commit Summary
* Bugfix: fix GEMDigiProducer not using new-style GEMDetId when producing hitMap
File Changes
* M SimMuon/GEMDigitizer/src/GEMDigiProducer.cc<https://github.com/bsunanda/cmssw/pull/14/files#diff-0> (2)
Patch Links:
* https://github.com/bsunanda/cmssw/pull/14.patch
* https://github.com/bsunanda/cmssw/pull/14.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#14?email_source=notifications&email_token=ABGMZOSYDNNDZP5LD5GYVMLPWZ6TJA5CNFSM4HO72RC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVN466A>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABGMZOVYARCJ557HHHCDRLLPWZ6TJANCNFSM4HO72RCQ>.
|
bsunanda
pushed a commit
that referenced
this pull request
May 22, 2020
…ms (L1Trigger/TrackFindingTMTT) (cms-sw#29381) * create separate PRs for the two L1TK packages * Improved KF efficiency at high eta * Moved MC data files to cms-data * Removed old file * Removed KF HLS to put instead in external library * Ran scram b code-format * Delete KF4ParamsComb.h.bak * Delete KF4ParamsCombIV.bak * Delete KF4ParamsCombV2.bak * Delete KF5ParamsComb.h.bak * Delete KF4ParamsComb.cc.bak * Delete KF4ParamsCombIV.bak * Delete KF4ParamsCombV2.bak * Delete KF5ParamsComb.cc.bak * L1 tk integration tmtt pre5 (#7) * Added CMS code style fixes * Removed old file * Reapplied stub b code-format * All code review changes (#13) * Fix clang errors (#14) * fixed clang error * directory for MC txt files * Fixed clang warnings + minor simplifications (#15) * tweak * tweak * Fixed clang warnings and small simplifications * Fixed clang warnings and small simplifications * All remaining review comments addressed (cms-sw#16) * Replaced vector size with empty function * Simplified DegradeBend and StubWindowSuggest * Fixed more review comments * More review comments * code reformat * Ran exhaustive clang tidy * Added library to BuildFile.xml (cms-sw#17) * Deleted TrackFindingTMT/data/README (cms-sw#18) * Added library to BuildFile.xml (This was already done yesterday. Not sure why it appears again) * README file in data directory deleted * Fix review comments (cms-sw#20) Co-authored-by: Louise Skinnari <louise.skinnari@cern.ch>
bsunanda
pushed a commit
that referenced
this pull request
Jul 1, 2020
Hgcal eol pulse update 112 x bis
bsunanda
pushed a commit
that referenced
this pull request
May 15, 2025
put nanoBPH_cff under nanoAOD and add entry for BPH in relval_nano matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Sunanda, I've been looking into the issues from Slava, and I found that the GEMDigiProducer was using directly the rawId when gathering simHits, causing it to not associate hits with the old id to the eta partitions of GEM, which are built with the newId. This should fix this, which resolves the "backward compatibility". That is, it should solve the missing digis problem but it doesn't change the station() plots though, which seems a separate issue.