CheckVersion was not properly casting integers to strings#6
Open
richardxia wants to merge 1 commit into
Open
Conversation
Properly casted integers to strings in the version check. Raise error if g++ version is too old
Owner
|
Thanks for reporting this. I may have already fixed it in this commit (which I haven't pushed to the main repository yet). Could you pull from this commit and see if it fixed the issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SConstruct, the CheckVersion() method was blindly comparing the parsed version number (as strings) with the required version number (always given as a tuple of integers) and would return true even if the version number was smaller than the required version. I cast the required tuple into an array of strings so that the comparison works as intended.
In addition, I added a check in the autoconf() method which raises an error if the g++ version is too low.