Address Zenodo publish review feedback (PR #37) - #40
Closed
brunomartinsmv wants to merge 1 commit into
Closed
Conversation
- Checkout the release tag in workflow_dispatch (not default branch) - Fail early with a clear error when ZENODO_ACCESS_TOKEN is missing - Derive CHANGELOG anchor from tag/version instead of hardcoding - Add mocked HTTP tests for the publish script - Remove empty ORCID field from .zenodo.json Co-authored-by: Bruno <brunomartinsmv@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the automated review of PR #37. The blocking issue (missing
scripts/publish_zenodo_release.py) was already resolved in PR #38; this PR addresses the remaining review items.Changes
workflow_dispatchnow checks out the requested release tag (github.event.inputs.tag) instead of the default branch.::error::whenZENODO_ACCESS_TOKENis not configured (using env var check, since secrets cannot be referenced inifconditionals)._changelog_section_anchor()parsesCHANGELOG.mdfor the version date instead of hardcoding200---2026-07-12.unittest.mockcovering CHANGELOG parsing, metadata generation, token validation, the full publish flow, and HTTP error handling..zenodo.json: removed empty"orcid": ""field.Notes
--deposition-id 18615164value should still be confirmed in the Zenodo dashboard before the first automated publish (record ID vs. latest deposition ID).README.md,CITATION.cff, anddocs/reproducibility.mdwhen a new Zenodo version is published.Test plan
python -m pytest tests/test_publish_zenodo_release.py -vpython -m ruff check scripts/publish_zenodo_release.py tests/test_publish_zenodo_release.py