Fail closed on every prune row decode#131
Merged
Merged
Conversation
Propagate malformed entry hashes, orphan blob hashes, and pruned external paths instead of silently skipping them. Add regressions proving malformed pruned paths and entry hashes roll back the import transaction.
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
Author
Recursive review summaryBlockersNone. Must-fixNone. Nice-to-haveNone. Reviewed the published diff for malformed SQLite typing, transaction rollback behavior, external-file safety, and regression coverage. All prune row-decoding paths now propagate errors before commit; the two test jobs and two security-audit jobs pass, the full local suite passes (214 tests), and the independent Codex review found no major issues on commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo test --all-features --locked(214 passed)cargo clippy --all-features --all-targets --locked(passes; existing warnings only)cargo check --no-default-features --lockedcargo check --no-default-features --features parquet --lockedgit diff --checkContext
Addresses the recursive review finding on #130: #130 (comment)
Stacked on #130.