Updated the code for new state empty title issue in History.setTitle method.#476
Open
rajkumar-duvva wants to merge 2 commits into
Open
Updated the code for new state empty title issue in History.setTitle method.#476rajkumar-duvva wants to merge 2 commits into
rajkumar-duvva wants to merge 2 commits into
Conversation
rajkumar-duvva
commented
Dec 7, 2017
rajkumar-duvva
left a comment
rajkumar-duvva
left a comment
Author
There was a problem hiding this comment.
updated title check condition with null and undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : In History.setTitle method, if new state title is empty, document title getting updated with empty value and title is showing the URL.
Fix : To fix this, document title is updated when new state title is not empty in History.setTitle method.