Skip to content

attempted fix for issue #339 - no more including host in hash on IE 8 and 9#366

Open
kontur wants to merge 1 commit into
browserstate:masterfrom
kontur:master
Open

attempted fix for issue #339 - no more including host in hash on IE 8 and 9#366
kontur wants to merge 1 commit into
browserstate:masterfrom
kontur:master

Conversation

@kontur

@kontur kontur commented Nov 29, 2013

Copy link
Copy Markdown

In Internet Explorer IE8 and IE9 there seems to be a problem that includes the host in the hash.

http://www.example.com/?page=foobar -> http://www.example.com/#http://www.exmaple.com?page=foobar&_suid=123456789
but    
http://www.example.com/directory/?page=foobar -> http://www.example.com/directory/#?page=foobar&_suid=123456789

I noticed that in History.getShortUrl the baseUrl reports "http://www.example.com/" with a trailing slash. Consequently, shortUrl.replace, does not match anything because of the superfluous "/" at the end of baseUrl. Removing the trailing slash fixes the problem, as shortUrl gets returned correctly.

I only applied this to the uncompressed html4+html5 bundle for jquery as I have not used the other library integrations.

@LiamKarlMitchell

Copy link
Copy Markdown

Merge please.

@ryanmcnz

ryanmcnz commented Jun 5, 2015

Copy link
Copy Markdown

Can confirm that this fixes the issue, just experienced this exact URL problem with the host duplicating into the hash.

Fix also works with the uncompressed bundle for native as well.

@kontur

kontur commented Jun 5, 2015

Copy link
Copy Markdown
Author

Thanks for confirming 👍

@adlq

adlq commented Sep 11, 2015

Copy link
Copy Markdown

I also can confirm this issue, please merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants