feat(copier): add --yes to npx all-contributors-cli for ci and test initial_commit and add_me_as_contributor#903
Conversation
|
setting |
34j
changed the title
--yes to npx all-contributors-cli for ci and test it--yes to npx all-contributors-cli for ci and test initial_commit and add_me_as_contributor
|
Changed to use add_me_as_contributor=yes only on Linux because the following error occurs in macOS tests. |
|
Single quotation marks do not seem to work on Windows, so this has been fixed. It should be fine now. |
|
@browniebroke What about this PR? This does not affect the results, and just makes only a few changes to copier.yml to extend the scope of the test. It also fixes issues in Windows (replaces single quotes with double quotes everywhere). (The commitizen category could also be “test” or "fix") |
| "setup_github": False, | ||
| "setup_pre_commit": False, | ||
| "add_me_as_contributor": False, | ||
| "add_me_as_contributor": platform == "linux", |
There was a problem hiding this comment.
Can we leave the base answers as is and test this in a dedicated test case?
There was a problem hiding this comment.
I removed only “add_me_as_contributor” and created a separate test case which enables it and tests .allcontributorsc. Is it enough? What is your concern?
| if CI and platform == "darwin": | ||
| pytest.skip("Skipping due to APi rate limit") |
There was a problem hiding this comment.
Turns out all-contributors-cli add makes some API calls to GitHub to resolve some details based on the username. Could we remove this test from CI or run it only once?
| --data 'open_source_license=MIT' \ | ||
| ${{ matrix.extra_options.value }} \ | ||
| --data 'initial_commit=yes' \ | ||
| --data 'add_me_as_contributor=yes' \ |
There was a problem hiding this comment.
Could we run it only on one of the combination instead of all of them please? Would reduce change of rate limit
2 participants
Description of change
Pull-Request Checklist
mainbranchFixes #0000