Transcribe of ceiling_species of solve_rate_cool_g#44
Open
ChristopherBignamini wants to merge 750 commits into
Open
Transcribe of ceiling_species of solve_rate_cool_g#44ChristopherBignamini wants to merge 750 commits into
ChristopherBignamini wants to merge 750 commits into
Conversation
remove a line that was made obsolete by PR grackle-project#224
…tweak cython does not need to be a runtime-dependency
…nstruction-tweaks Pygrackle test instruction tweaks
fix a typo in a CMake variable name
Tweak cython-handling in build-system
…Warnings Enable Compiler Warnings in a CI job
…lding_length_fix H2 self shielding length scale factor fix
Superficial Website Documentation Tweaks
[newchem-cpp] Minor model test refactor and adding model comparison option
…eaks fixing up config.yml
…eaks address the remaining compiler warnings
Fix spacing issues in docs.
Relocated all CMake-dependency-information into dependencies.cmake
[newchem-cpp] Attempted merge of newchem-cpp with main
By adding this file, GitHub adds a nicely labeled tab when you scroll down to the README Numpy and Scipy both do something similar (but I'm honestly not sure where the file that does this is in the Numpy repository)
This is an extremely popular theme. While I really like how it looks, that's not my main motivation. My motivation is formatting of wide-tables - this is a problem with the ReadTheDocs theme. - The RTD theme made a deliberate design decision to make all wide tables scrollable (rather than supporting wraparound) without a straight-forward way to disable it. - This is a long-standing problem. See this 10 year old issue, readthedocs/sphinx_rtd_theme#117. - While this issue suggests some workarounds (we actually use one of them in Enzo-E), there are some flaws with them.[^1] - In comparison, the furo theme handles wide tables much more elegantly. To compare them, see the table at the top of the page titled "Integrating Grackle into your Application" If we dislike Furo, we can just stick with ReadTheDocs. I can try my hand at implementing the fix again. (I just thought I would suggest this patch before adopting a slightly hacky solution) [^1]: I actually tried adding one of the fixes to Grackle like 9 months ago, and there was an issue. I'm fuzzy on the details. I think it had to do with sizing of the table on different devices (and it was inconsistent between local builds and a ReadTheDocs build).
The *Great Renaming:* `gracklepy` edition
…e/initial-step_rate_newton_raphson [newchem-cpp] initial transcription of `step_rate_newton_raphson`
…phson-cleanup-1of2
…phson-cleanup-1of2
…' into gen2024transcribe/solve_rate_cool-refactor
…' into gen2024transcribe/lookup_cool_rates0d
…scribe/lookup_cool_rates0d_cleanup
…2024transcribe/calc_temp_cloudy_g I needed to introduce the bugfix from PR grackle-project#367.
…cribe/scale_fields_table
…cribe/interpolate-wrappers
…nscribe/calc_tdust_3d
…/scale_fields_dust
Background ---------- Previously we had replaced 99% uses of the Flake8 linter with the Ruff linter (not to be confused with the Ruff formatter). We had continued to use the Flake8 linter to deal with the following 2 files: 1. **gracklepy/utilities/testing.py** 2. **gracklepy/__init__.py** In more detail, we were suppressing certain warnings in these 2 files from Flake8, and transistioning to using the Ruff formatter for these files would involve making a few changes. More recently PRs grackle-project#368 and grackle-project#369 introduced the required changes into the main branch. Now that those changes have been ported to the newchem-cpp branch, we are able to make this change. What Changed ------------ I essentially changed 3 things: 1. We no longer install and use flake8 in the continuous integration 2. I removed the **setup.cfg** file (it was **only** being used to track flake8 configuration information 3. I needed to tweak **pyproject.toml** to both: - stop excluding the **gracklepy/utilities/testing.py** and **gracklepy/__init__.py** files from the linter - stop listing flake8 as a development dependency
…e/step_rate_newton_raphson-cleanup-1of2 [newchem-cpp] `step_rate_newton_raphson` cleanup (1/2)
…e/solve_rate_cool-refactor [newchem-cpp] light refactoring of `solve_rate_cool`
[newchem-cpp] Remove last references to `Flake8`
…_dust' into gen2024_transcribe_ceiling_species
…024_transcribe_ceiling_species
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.