Gen2024transcribe/solve rate cool refactor#42
Closed
mabruzzo wants to merge 669 commits into
Closed
Conversation
…te job to the corelib-tests
Originally one job ran the tests after building pygrackle as a standalone package (i.e. the core Grackle is compiled as part of pygrackle). The other job ran the tests with versions of pygrackle where we explicitly built the core library (with both build-systems) as a separate step from building pygrackle.
In these cases, we only run a subset of the test-suite (the much faster component). This seems reasonable since we are already running the answer-tests with the version of pygrackle configured that automatically compiled the core-library as part of the build process. This should save a lot of time
Optimize circleci workflows
remove 2 unneeded files
…sting-without-editable-install Support running subset of pygrackle test without a an editable install
remove a line that was made obsolete by PR grackle-project#224
…tweak cython does not need to be a runtime-dependency
…nstruction-tweaks Pygrackle test instruction tweaks
fix a typo in a CMake variable name
Tweak cython-handling in build-system
…Warnings Enable Compiler Warnings in a CI job
…lding_length_fix H2 self shielding length scale factor fix
…ranscribe/Implement-SpLUT-with-XMacros
…n2024transcribe/SpeciesLUTFieldAdaptor
…e/consistency-tweaks [newchem-cpp] Consistency tweaks: `GrainSpeciesCollection` and `cool_multi_time_g`
…ranscribe/Implement-SpLUT-with-XMacros
…n2024transcribe/SpeciesLUTFieldAdaptor
…ranscribe/initial-step_rate_newton_raphson
…o gen2024transcribe/step_rate_newton_raphson-cleanup-1of2
…e/internal_types_updates [newchem-cpp] internal scratch-buffer interface update
…e/Implement-SpLUT-with-XMacros [newchem-cpp] Refactor such that SpLUT is implemented with XMacros
…e/SpeciesLUTFieldAdaptor [newchem-cpp] Introduce `SpeciesLutFieldAdaptor`
The *Great Renaming:* `gracklepy` edition
…e/initial-step_rate_newton_raphson [newchem-cpp] initial transcription of `step_rate_newton_raphson`
…phson-cleanup-1of2
…phson-cleanup-1of2
…' into gen2024transcribe/solve_rate_cool-refactor
Author
|
superseded by PR grackle-project#377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This must be reviewed after #30
This did a little bit of cleanup in
solve_rate_cool_g. I telegraphed in some comments a while back that I wanted to improve the mask behavior to make it a little more logical. We introduceitmask_gs, to replace the practice of temporarily overwritingitmaskand then reverting it later. I think the resulting code is a lot logical.While I was doing this, I realized that I could slightly refactor the logic where we set the values of
itmask_gsanditmask_nr. This is more concise and I think the logic is a little more cleanI have manually confirmed that the tests all pass