transcribe lookup_cool_rates0d 1/2#31
Closed
mabruzzo wants to merge 678 commits into
Closed
Conversation
lookup_cool_rates0dlookup_cool_rates0d 1/2
This was referenced Feb 16, 2025
…te job to the corelib-tests
Originally one job ran the tests after building pygrackle as a standalone package (i.e. the core Grackle is compiled as part of pygrackle). The other job ran the tests with versions of pygrackle where we explicitly built the core library (with both build-systems) as a separate step from building pygrackle.
In these cases, we only run a subset of the test-suite (the much faster component). This seems reasonable since we are already running the answer-tests with the version of pygrackle configured that automatically compiled the core-library as part of the build process. This should save a lot of time
Optimize circleci workflows
remove 2 unneeded files
…sting-without-editable-install Support running subset of pygrackle test without a an editable install
remove a line that was made obsolete by PR grackle-project#224
…tweak cython does not need to be a runtime-dependency
…nstruction-tweaks Pygrackle test instruction tweaks
fix a typo in a CMake variable name
Tweak cython-handling in build-system
…ranscribe/Implement-SpLUT-with-XMacros
…n2024transcribe/SpeciesLUTFieldAdaptor
…e/consistency-tweaks [newchem-cpp] Consistency tweaks: `GrainSpeciesCollection` and `cool_multi_time_g`
…ranscribe/Implement-SpLUT-with-XMacros
…n2024transcribe/SpeciesLUTFieldAdaptor
…ranscribe/initial-step_rate_newton_raphson
…o gen2024transcribe/step_rate_newton_raphson-cleanup-1of2
…e/internal_types_updates [newchem-cpp] internal scratch-buffer interface update
…e/Implement-SpLUT-with-XMacros [newchem-cpp] Refactor such that SpLUT is implemented with XMacros
…e/SpeciesLUTFieldAdaptor [newchem-cpp] Introduce `SpeciesLutFieldAdaptor`
The *Great Renaming:* `gracklepy` edition
…e/initial-step_rate_newton_raphson [newchem-cpp] initial transcription of `step_rate_newton_raphson`
…phson-cleanup-1of2
…phson-cleanup-1of2
…' into gen2024transcribe/lookup_cool_rates0d
Author
|
superseded by grackle-project#378 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR must be reviewed after #30
This was the step 1 of 2 for transcribing
lookup_cool_rates0d.0or1). Essentially, we introduced a few local variables to temporarily store these values and then passed the variables as arguments (this overcomes a limitation of the transcription tool)FORTRAN_NAME(cool1d_multi_g),FORTRAN_NAME(lookup_cool_rates1d_g),FORTRAN_NAME(rate_timestep_g)with the C++ wrappers (that use the reduced arg lists)grackle_field_data, this needed to change:grackle_field_data(distinct from the instance passed to Grackle's API).step_rate_gand then heavily modified. That logic is more directly addressed in the next PRColRecRxnRateCollection,PhotoRxnRateCollection, andGrainSpeciesCollectiontypes since the C++ use these types to pass around large bundles of quantities (there was a bunch of search-and-replace done to avoid breaking logic at the end of the function)IndexRangeThe that the
cool1d_multi_g,lookup_cool_rates1d_g, andrate_timestep_groutines are only called from C++ source files AND the fact they are only called through the C++ wrappers (i.e.grackle::impl::fortran_wrapper::cool1d_multi_g,grackle::impl::fortran_wrapper::lookup_cool_rates1d_g, andgrackle::impl::rate_timestep_g) is an important milestone. It means that they can be replaced with transcribed function.The resulting code in this PR is still very messy. But, I choose to make this PR at this point because it was a point when @ChristopherBignamini could working from this branch in order to transcribe
cool1d_multi_gin parallel with my efforts. In fact, it was originally my intention to break this particular PR into smaller (slightly more logical) pieces, but I prioritized "getting done" in order to stop being a bottleneck for @ChristopherBignaminiAnother PR has been posted to further cleanup
lookup_cool_rates0d.I have confirmed that this PR passes all tests