internal scratch-buffer interface update#26
Closed
mabruzzo wants to merge 264 commits into
Closed
Conversation
…for transcribing)
this parallel clause is used when converting from comoving to proper
this parallel clause is used when converting from proper to comoving
Removed unused local variables from `calc_tdust_3d_g` that followed the naming scheme used in solve_rate_cool for tracking the mass density for the mass densities of various metal species used in dust chemistry. There was logic to convert between proper and comoving units for each of these variables, but they were not actually used for anything (which is a good thing since they were never initialized). These variable declarations were probably blindly copied from somewhere else and were never removed.
Removed unused local variables from `calc_tdust_3d_g` that followed the naming scheme used in solve_rate_cool for tracking the mass density for tracking the mass densities of various metal species used in metal chemistry. There was logic to convert between proper and comoving units for each of these variables, but they were not actually used for anything (which is a good thing since they were never initialized). These variable declarations were probably blindly copied from somewhere else and were never removed.
…arts of the code.
`make dep` previously didn't work correctly with some of the C++ files (I think because I changed the suffix of the names of some headers)
…gHeatingScratchBuf struct.
…nInterpScratchBuf
This is the last commit in a sequence where we were refactoring the local variable declarations. The routine should now work properly with OpenMP, but we can't test that since OpenMP-support was broken in earlier commits to the gen2024 branch (before we began the transcription). More simplifications can certainly be made, but it is worth holding off on that until after we have transcribed more of Grackle.
…cessary forward-declarations (since they already exist within grackle.h).
Originally I tried to fix the problem properly, by having grackle_macros.h directly include grackle.h. But, this produced problems related to the fact that some function are redeclared slightly differently between grackle.h and within the source files (the difference is OK since it is just related to the appearance of `const`). A number of pending PRs gradually fix this disagreement throughtout the codebase. Thus, we are going to hold off on "fixing it properly" until those other PRs are merged
[newchem-cpp] Reverting minor changes to abundance corrections
[newchem-cpp] 2 minor bugfixes following last week's merge
I a prior merge, I accidently duplicated "initialize_rates.lo" in ``src/clib/Make.config.objects``. This caused obviously introduced some linking problems with the classic build-system
…cribe/solve_rate_cool_g
While it looks like there is a large deviation from the older results, Britton previously did a lot of work investigating this. It turns out that the example is in the regime where Grackle keeps overshooting the equlibrium state. We just aren't at the "same point of overshoot"
…core-lib test-suite
…d-standard Register temporary gold standard
When I changed the type of `end_int` argument of ``interpolate_3Dz_g`` to use a 64-bit integer, I forgot to modify the declaration used within the InterpolationTest.Interpolate3Dz unit-test
…cribe/solve_rate_cool_g
…ribe/consistency-tweaks
…cribe/internal_types_updates
Author
|
superseded by grackle-project#333 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This must be reviewed after #25
This consists of 2 commits that tweak the general interface of the internal-type I have been creating (their nominal role is to carry around collections of scratch buffers). Basically I formalize the idea that each of these types should support the visitor design pattern for visiting the data-members of these types (we were already doing to help with allocation and destruction).
A longer description of the design pattern is provided within the modified files.
This is important for the at least the initial transcription of
step_rate_newton_raphson. We may be able to get rid of this machinery down the road.This machinery could be very useful for aggregating memory allocations, the initial port to GPUs (i.e. copying data to and from the GPU), and debugging (e.g. printing out the contents of the buffers tracked by a particular buffer in a nicely formatted manner)
I have manually confirmed that this passes all tests