Allow RBR To Recognize Device When Bootstraping And Hotswaping

[matt001k]

What changed?

Check the last time data has been received from the RBR agnostic of the value being properly parsed.
Always probe for attached RBR if _type is UNKNOWN.

How does it make Bristlemouth better?

This allows the RBR application to set the RBR if one has not been set yet and reinstates hot swapping RBR modules as this bug also broke that functionality.

This happened due to the fact that _last_data_time would never get set because handleDataString would always return false (the function could not parse the string because the application did not know the _type of RBR attached).
_last_data_time should be set no matter if handleDataString returns true or false as this variable is meant to be used to determine when valid data was last received, not if the data was parsed properly. This allows the application to properly probe the RBR sensor.

Testing

The following setup was used for testing:

• RS232 RBR module on v0.13.11-rc.3
• 1 RBR coda³ T.D
• 1 RBR coda³ T

Initially I deleted the rbrCodaType config in the system configs:

I would repeatedly get attempting FTL recovery print statements and the rbrCodaType would never get set.

I then proceeded to flash the fix in this PR.
Immediately the rbrCodaType was set:

I then hot swapped from the RBR coda³ T.D to the RBR coda³ T and was able to see the config get set and changed upon the next probing window:

I then hot-swapped back to the RBR coda³ T.D and it was properly recognized and the configuration was set upon the next probing window:

Where should reviewers focus?

I added an extra safety rail when the _type is not set (UNKNOWN).
Do you believe this is needed?
It could mess with the probing window, but also data should not be getting transmitted up Bristlemouth if _type is not set.

Checklist

• Add or update unit tests for changed code
• Ensure all submodules up to date. If this PR relies on changes in submodules, merge those PRs first, then point this PR at/after the merge commit
• Ensure code is formatted correctly with clang-format. If there are large formatting changes, they should happen in a separate whitespace-only commit on this PR after all approvals.

[victorsowa12]

Nice find! LGTM!