Skip to content

fix #36 validation does not support list elements#37

Merged
bristermitten merged 19 commits into
masterfrom
36-validation-does-not-support-list-elements
Jun 12, 2026
Merged

fix #36 validation does not support list elements#37
bristermitten merged 19 commits into
masterfrom
36-validation-does-not-support-list-elements

Conversation

@bristermitten

@bristermitten bristermitten commented Jun 11, 2026

Copy link
Copy Markdown
Owner
  • fix validation does not support list elements etc #36 by refactoring generated serdes code to be lower level and rely more on mittenlib serdes code rather than outsourcing
  • add jacoco and improve test coverage quite a bit
  • move to palantir javapoet and add a bit of javadocs to generated code
  • add proper public interface for saving configs

Replaced thrown IllegalStateException and IllegalArgumentException with
MessagerUtils.error in ConfigClassParser, CustomDeserializers, and
CustomSerializers to ensure compilation gracefully fails and displays
helpful messages. Also fixed ConfigClassParser ignoring enclosed
non-config classes and added related tests.
… tests

Split multiple public classes into separate files in DeserializerGeneratorTest.
Corrected EnumParsingSchemes imports and assertions in TypesUtilTest to
ensure they compile properly and pass.
… and code generators

Made several internal component constructors public to facilitate unit
testing. Added tests for GenericTypeDeserializerGenerator, ElementsFinder,
PrivateAnnotations, and TypeSpecUtil, bringing overall annotation-processor
test coverage significantly higher.
@bristermitten bristermitten linked an issue Jun 11, 2026 that may be closed by this pull request
@bristermitten bristermitten added the enhancement New feature or request label Jun 11, 2026
@bristermitten bristermitten merged commit 4c3233b into master Jun 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validation does not support list elements etc

1 participant