sio/csupio, sio/parquetio: fix non-Boolean metadata filter result handling#7124
Open
nwt wants to merge 1 commit into
Open
sio/csupio, sio/parquetio: fix non-Boolean metadata filter result handling#7124nwt wants to merge 1 commit into
nwt wants to merge 1 commit into
Conversation
…dling csupio.VectorReader.ConcurrentPull can skip objects incorrectly because csupio.pruneObject can produce a false positive when the metadata filter evaluates to a non-Boolean value, like null or an error. Fix this by checking explicitly for super.False instead of calling super.Value.AsBool. parquet.VectorReader.ConcurrentPull has a similar problem and fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csupio.VectorReader.ConcurrentPull can skip objects incorrectly because csupio.pruneObject can produce a false positive when the metadata filter evaluates to a non-Boolean value, like null or an error. Fix this by checking explicitly for super.False instead of calling super.Value.AsBool.
parquet.VectorReader.ConcurrentPull has a similar problem and fix.