Skip to content

A few minor fixes for gen_ver.py#161

Open
keestux wants to merge 2 commits into
bright-tools:masterfrom
keestux:feat/minor-fixes-genver
Open

A few minor fixes for gen_ver.py#161
keestux wants to merge 2 commits into
bright-tools:masterfrom
keestux:feat/minor-fixes-genver

Conversation

@keestux

@keestux keestux commented Feb 24, 2024

Copy link
Copy Markdown
Contributor

There are three changes:

  • by using the --tags option to git describe we now get a better version (v0.8 something instead of v0.7 something)
  • by using --dirty we don't need to check for changes with extra Python code
  • the generated header file now gets a newline at the last line (as recommended by POSIX)

There really is no excuse to _not_ have an newline on the last line of a
file.
@keestux

keestux commented Apr 2, 2024

Copy link
Copy Markdown
Contributor Author

@bright-tools any chance to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant